episodes-platform/shared-snippets
3
0
Fork 1
Code Issues Pull Requests 1 Packages Projects Releases Wiki Activity

ISEPOS-2280 Added base loggers scripts #1

Open
ymlesni wants to merge 8 commits from ymlesni/shared-snippets:feature/ISEPOS-2280-mechanizm-raportowania-informacji-z-aplikacji-do-pliku-z-logami into main
pull from: ymlesni/shared-snippets:feature/ISEPOS-2280-mechanizm-raportowania-informacji-z-aplikacji-do-pliku-z-logami
merge into: episodes-platform:main
Conversation 0 Commits 8 Files Changed 3 +5 -5
3 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 03616dcac6 - Show all commits

2
matlab/logging/base_logger.m
View File

@ -39,7 +39,7 @@
% logger.info('Some info')
%
asia commented 2024-09-26 13:32:36 +02:00
Outdated
Review
Copy Link

Can we put here an example with error object? So that the stack trace of the exception gets logged.

Can we put here an example with error object? So that the stack trace of the exception gets logged.
ymlesni commented 2024-09-30 23:53:23 +02:00
Outdated
Review
Copy Link

Base logger has been enchanced and example for error logging has been added.

Base logger has been enchanced and example for error logging has been added.
% try
% error('Simulated error for stack trace logging');
% % some code causing exception
% catch err
% logger.error('An error occurred:', err);
% end

2
octave/logging/base_logger.m
View File

@ -39,7 +39,7 @@
% logger.info('Some info')
%
% try
% error('Simulated error for stack trace logging');
% % some code causing exception
% catch err
% logger.error('An error occurred:', err);
% end

6
python/logging/base_logger.py
View File

@ -43,9 +43,9 @@ def getDefaultLogger(name):
logger = getDefaultLogger(__name__)
logger.info("This is an info message.")
asia commented 2024-09-26 13:33:22 +02:00
Outdated
Review
Copy Link

An example with an error with logging stack trace would be convenient here

An example with an error with logging stack trace would be convenient here
ymlesni commented 2024-10-01 00:02:04 +02:00
Outdated
Review
Copy Link

Example for error with stack trace logging has been added.

Example for error with stack trace logging has been added.
try:
raise Exception('Exception for example.')
except Exception as e:
logger.error('An error occurred:', exc_info=True) # Log with stack trace
# some code causing exception
asia commented 2024-10-02 16:59:43 +02:00
Outdated
Review
Copy Link

Maybe just put here some placeholder meaning that this is a code that may produce an error

Maybe just put here some placeholder meaning that this is a code that may produce an error
ymlesni commented 2024-10-03 08:37:17 +02:00
Outdated
Review
Copy Link

Ok, I will do the same for Matlab and Octave versions.

Ok, I will do the same for Matlab and Octave versions.
except Exception:
logger.exception('An error occurred')
asia commented 2024-10-02 16:59:07 +02:00
Outdated
Review
Copy Link

We have except Exception as e but the e is not used anywhere... is this correct?

We have `except Exception as e` but the `e` is not used anywhere... is this correct?
h.siejkowski commented 2024-10-02 19:02:26 +02:00
Outdated
Review
Copy Link

Maybe it is good to use here the logger.exception() (doc) method as a showcase.

Maybe it is good to use here the `logger.exception()` ([doc](https://docs.python.org/3/library/logging.html#logging.Logger.exception)) method as a showcase.
ymlesni commented 2024-10-03 08:36:37 +02:00
Outdated
Review
Copy Link

e could be used to process exception further, but it is not necessary for example, I will remove it.
Would adding logger.exception() as a additional option be a good idea (to still showcase how to log exception at chosen log level)? For now I will change to logger.exception().

`e` could be used to process exception further, but it is not necessary for example, I will remove it. Would adding `logger.exception()` as a additional option be a good idea (to still showcase how to log exception at chosen log level)? For now I will change to `logger.exception()`.
"""
logger = logging.getLogger(name)