ISEPOS-2325 Fix 'NoneType' object is not iterable #1

mieszkomakuch · 2025-03-11T14:35:08+01:00

mieszkomakuch commented

2025-03-11 14:35:08 +01:00

Raise error if there is no b_method set: raise ValueError("Please chose an option for b-value")

mieszkomakuch added 2 commits 2025-03-11 14:35:09 +01:00

ISEPOS-2325 Raise error if there is no b_method set: raise ValueError("Please chose an option for b-value") d4c0fff9af

ISEPOS-2325 Added a default value like "b" to maxmagnitude_wrapper.py to fix 'NoneType' object is not iterable ac7933bd2c

mieszkomakuch commented

2025-03-21 11:40:41 +01:00

I've enabled development mode on the epos.isl instance for the MaxMagnitude app. You can find the app, along with its input data, in the Test user directory:

-> TicketReproduceData/ISEPOS-2325/84. MaxMagnitudeDPModels

To test the changes, try switching between:

Built-in version (from the artifact) — this should reproduce the 'NoneType' object is not subscriptable error
Development branch: official-apps/MaxMagnitudeDPModels/BRANCH/bugfix/ISEPOS-2325-fix-nontype-object-bug — this version includes the bugfix

I've enabled development mode on the `epos.isl` instance for the **MaxMagnitude** app. You can find the app, along with its input data, in the **Test** user directory: -> [TicketReproduceData/ISEPOS-2325/84. MaxMagnitudeDPModels](https://epos.insilicolab-dev.grid.cyfronet.pl/?lang=en#workspace:TicketReproduceData/ISEPOS-2325/84.%20MaxMagnitudeDPModels) To test the changes, try switching between: - **Built-in version** (from the artifact) — this should reproduce the `'NoneType' object is not subscriptable` error - **Development branch:** `official-apps/MaxMagnitudeDPModels/BRANCH/bugfix/ISEPOS-2325-fix-nontype-object-bug` — this version includes the bugfix

Zrzut ekranu 2025-03-21 o 11.34.50.jpg

151 KiB

mieszkomakuch requested review from asia 2025-03-21 11:43:48 +01:00

mieszkomakuch requested review from ymwenda 2025-03-21 11:43:49 +01:00

asia requested changes 2025-03-21 12:57:41 +01:00

Dismissed

src/maxmagnitude_wrapper.py Outdated

						
				@ -38,3 +38,3 @@

				    parser.add_argument("--ssd", help="Static stress drop (in Pa).", type=float, default=3000000)

				    parser.add_argument("--C", help="Geometrical constant.", type=float, default=0.95)

				    parser.add_argument("--b_value_type", help="b-value type: parameter of type 'TEXT'", action='append')

				    parser.add_argument("--b_value_type", help="b-value type: parameter of type 'TEXT'", action='append', default="b")

asia commented

2025-03-21 12:57:36 +01:00

With this setting, if you don't check any of the options in the interface, the app gets executed properly, but for the user it looks like it was without any b option selected, while underneath something is selected, and the user doesn't know about it. I wouldn't set this option here, and let the error be comunicated from the app (that nothing was selected). In this way we'll be consistent with what is shown in the interface.
Then, to avoid the error altogether, in the interface we should validate the field to ensure something is selected.

With this setting, if you don't check any of the options in the interface, the app gets executed properly, but for the user it looks like it was without any b option selected, while underneath something is selected, and the user doesn't know about it. I wouldn't set this option here, and let the error be comunicated from the app (that nothing was selected). In this way we'll be consistent with what is shown in the interface. Then, to avoid the error altogether, in the interface we should validate the field to ensure something is selected.

screenshot-epos_insilicolab-dev_grid_cyfronet_pl-2025_03_21-12_52_26.png

86 KiB